Explicitly expose version to avoid release script failure #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philiptaron
approved these changes
Apr 10, 2024
|
Oh I like that idea more, lemme try something.. |
|
Done, I like it more like this :D |
philiptaron
approved these changes
Apr 10, 2024
default.nix
Outdated
| @@ -31,15 +31,18 @@ let | |||
| nix-store --init | |||
| ''; | |||
|
|
|||
| # Determine version from Cargo.toml | |||
| version = (builtins.fromTOML (builtins.readFile ./Cargo.toml)).package.version; | |||
There was a problem hiding this comment.
Suggested change
| version = (builtins.fromTOML (builtins.readFile ./Cargo.toml)).package.version; | |
| version = (lib.importTOML ./Cargo.toml).package.version; |
default.nix
Outdated
Comment on lines
37
to
40
| # The build with all internal derivation attributes exposed | ||
| buildUnredacted = pkgs.callPackage ./package.nix { | ||
| inherit nixpkgsLibPath initNix runtimeExprPath testNixpkgsPath version; | ||
| }; |
There was a problem hiding this comment.
I'd just leave this in lazyDerivation now that it isn't used elsewhere.
lazyDerivation limits which attributes are exposed, and version is not currently one of them, so we need to explicitly expose it. This fixes this CD failure: https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8637321506/job/23679230914
|
Nice suggestions, done! |
philiptaron
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazyDerivation limits which attributes are exposed, and version is not currently one of them, so we need to explicitly expose it.
This fixes this CD failure:
https://github.com/NixOS/nixpkgs-check-by-name/actions/runs/8637321506/job/23679230914
This was accidentally introduced in #40 (should've made a separate PR for the first commit after all!)