feat: support auto-detecting changes #364
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mainly an experiment to gather feedback. It's lacking documentation and tests, especially in zoneless mode.
cexbrayat
reviewed
Jul 7, 2024
There was a problem hiding this comment.
Nice first step!
A few things:
- I'm not a fan of async* methods. I don't exactly know how, but I would prefer to have the same APIs (maybe we can have overloaded versions? Maybe we return a different test element? Combined with eslint checks on pending promises, we might be able to know if await is needed or not)
- Could we have a way to configure it globally?
- The commit and PR titles have a typo
cexbrayat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly an experiment to gather feedback.
It's lacking documentation and tests, especially in zoneless mode.