MCS-1815 MCS-1930 Webenabled Updates: Production-Ready Server and Configurable Command Line Settings #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ThomasSchellenbergNextCentury
commented
Dec 5, 2023
ThomasSchellenbergNextCentury
commented
- By default, use the production-ready "waitress" library (which supposedly supports Windows) to serve the webenabled flask app. Note that the version I pinned in the requirements file is simply the most recent version.
- All of the "info" logs are now at "debug" level.
- Added argparse with the following optional settings: host, port, dev (development server), debug (debug logging)
- Ensure the log level is properly passed to all scripts.
…ntTest MCS-1976 - Fix integration test for windows
…y default. Also added configurable command line settings.
ThomasSchellenbergNextCentury
requested review from
rartiss55,
phile-caci and
NDCACI
MCS-1988 Added Eval 7 novel objects to schema doc.
|
This branch has some merge conflicts |
|
@NDCACI Conflicts are now resolved. |
|
The file "docs/source/schema.rst" got added during the merge fix. It looks like it might got pulled in by accident. Is it supposed to be in this PR? |
|
@NDCACI Nope! Hmm... Well, just ignore all the files outside the |
NDCACI
approved these changes
Dec 12, 2023
rartiss55
approved these changes
Dec 12, 2023
ThomasSchellenbergNextCentury
merged commit e2f3f0e
into
new-webenabled
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.