Skip to content

Commit

Permalink
fpr_my_fish_sp now processes species codes passed strings seperated…
Browse files Browse the repository at this point in the history
… by commas or semi colons since new `bcfishpass.crossing.vw` outputs use

semi-colons vs the past convention of commas closes #88
  • Loading branch information
NewGraphEnvironment committed May 30, 2024
1 parent ceb3f7c commit 04f43e5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
# Development version
* `fpr_my_fish_sp` now processes species codes passed as comma seperated character vectors or semi colon seperated character vectors. This allows for more flexibility in the input of species codes. Thanks @lucy-schick ! closes [#90](https://github.com/NewGraphEnvironment/fpr/issues/89)
* reorder `kableExtra` calls in `fpr_table_bcfp_html` so that `kableExtra::add_footnote` is called after `kableExtra::kable_styling` to close
[#87](https://github.com/NewGraphEnvironment/fpr/issues/87). Remove redundant call to `fpr_kable`) in `fpr_table_bcfp_html`
* remove all_spawning_rearing_* columns from fpr_xref_crossings picklist so can build fpr_table_bcfp_html close [#88](https://github.com/NewGraphEnvironment/fpr/issues/88)
Expand Down
2 changes: 1 addition & 1 deletion R/report.R
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ fpr_my_fish_sp <- function(...,
str_to_pull <- stringr::str_replace_all(
(fpr_my_bcfishpass(..., col_pull = {{col_pull}})),
c("\\{" = "","\\}" = "")) %>%
strsplit(., ",") %>%
strsplit(., c(",|;")) %>%
unlist()
fishbc::freshwaterfish %>%
dplyr::filter(Code %in% str_to_pull &
Expand Down

0 comments on commit 04f43e5

Please sign in to comment.