Fix SFTPGo service port check in restore action #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephdl
force-pushed
the
test_sftp_port
branch
from
0559786
to
4483075
Compare
DavidePrincipi
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
The fix moves transforms the original issue into something else that the user must address anyway at some time in the future. I can approve, but
restartis not needed afterenable --now.- patch size can be smaller: if the port is in use, exit immediately.
Edit: why not using agent.tcp_port_in_use() instead of defining a similar function here?
stephdl
force-pushed
the
test_sftp_port
branch
from
b2fb312
to
eee3d69
Compare
stephdl
force-pushed
the
test_sftp_port
branch
from
eee3d69
to
0849f77
Compare
DavidePrincipi
approved these changes
Sep 3, 2024
|
For now I close this PR, the fix cannot be for webserver but it needs a more complex solution in the restoration process, we have many other apps concerned by the same behavior, the fact the static port is still used by the previous module or the restoration of the module as new module causes trouble because a static port cannot be bound two times https://mattermost.nethesis.it/nethesis/pl/grp4er6qpfnt7q13k8caydh73w |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request fixes an issue where the SFTPGo service port was not properly checked before starting it in the restore action. The commit adds a new function to check if the port is in use for both IPv4 and IPv6. If the port is not in use, the service is started successfully. If the port is already in use, a message is printed to indicate that the service needs to be restarted manually later.
NethServer/dev#7001