Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the restore procedure #8

Merged
merged 4 commits into from
Apr 11, 2024
Merged

Fix the restore procedure #8

merged 4 commits into from
Apr 11, 2024

Conversation

DavidePrincipi
Copy link
Member

@DavidePrincipi DavidePrincipi commented Apr 10, 2024

This PR introduces some changes in the backup/restore procedure

  1. fixes a restore bug, where LOKI_ADDR and LOKI_HTTP_PORT are overwritten. The restored Loki instance can't work with the values stored in the backup. It must use the node allocated values.
  2. fixes a restore bug: Traefik needs a restart to expand the restored credentials inside its configuration file
  3. enhancement of LOKI_HTTP_PORT variable usage. Use a fixed port number in the Pod private namespace: 8080
  4. fixes the missing LOKI_ACTIVE_TO value after an instance restoration

Refs NethServer/dev#6890

IP address and port number are allocated by the cluster: do not
overwrite them during the restore from backup.

Traefik must be restarted to expand restored credentials.
As the pod network namespace is private, we can use a fixed port number
to avoid confusion. The allocated dynamic port number is necessary only
for the public side of the pod.
@DavidePrincipi DavidePrincipi force-pushed the fix-restore branch 2 times, most recently from 8484343 to 276999d Compare April 11, 2024 14:20
- Clean up volume before Restic restores it
- Restore the "active from" timestamp
- Restore the "active to" timestamp, by reading it from volume
- Do not restore credentials and tokens: use new ones
@DavidePrincipi DavidePrincipi merged commit 377499a into main Apr 11, 2024
1 check passed
@DavidePrincipi DavidePrincipi deleted the fix-restore branch April 11, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant