Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a FQDN for LDAP domain and migration scripts instead of directory.nh #90

Merged
merged 10 commits into from
Nov 25, 2024

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Nov 14, 2024

Update the LDAP configuration and migration scripts to utilize a fully qualified domain name (FQDN) given by the sysadmin, instead of the hardcoded value directory.nh, enhancing flexibility and accuracy in domain handling.

NethServer/dev#7103

image
image
image
image
image
image
image

@stephdl stephdl marked this pull request as draft November 14, 2024 14:13
@nethbot
Copy link
Member

nethbot commented Nov 14, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.3.pr90.g66a986d.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 14, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.3.pr90.g1c7aec1.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 15, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.2.pr90.gc68c5c1.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 18, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.3.pr90.g1e8448d.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 18, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.2.pr90.g1bd8c0f.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 18, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.3.pr90.g961a06e.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 20, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.4.pr90.gbacf1ef.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 20, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.4.pr90.g4da15f8.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 21, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.5.pr90.g3d88129.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 21, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.5.pr90.g573cb09.ns7.x86_64.rpm x86_64

@stephdl stephdl marked this pull request as ready for review November 21, 2024 15:14
@stephdl stephdl changed the title Use FQDN for LDAP domain and migration scripts Use a FQDN for LDAP domain and migration scripts instead of directory.nh Nov 21, 2024
@nethbot
Copy link
Member

nethbot commented Nov 22, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.6.pr90.gd62d99d.ns7.x86_64.rpm x86_64

api/connection/read Outdated Show resolved Hide resolved
api/connection/read Outdated Show resolved Hide resolved
api/connection/read Outdated Show resolved Hide resolved
api/connection/read Outdated Show resolved Hide resolved
root/usr/sbin/ns8-join Outdated Show resolved Hide resolved
ui/public/i18n/language.json Outdated Show resolved Hide resolved
ui/src/views/Dashboard.vue Outdated Show resolved Hide resolved
@nethbot
Copy link
Member

nethbot commented Nov 22, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.7.pr90.g695a337.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 22, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.9.pr90.gc04f564.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Nov 22, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.9.pr90.g17f5cd1.ns7.x86_64.rpm x86_64

Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good but I'd ask a second glance to Davide

Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope tests will confirm it.

ui/src/views/Dashboard.vue Show resolved Hide resolved
Co-authored-by: Davide Principi <[email protected]>
@nethbot
Copy link
Member

nethbot commented Nov 25, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.18-1.10.pr90.gdcbdfc2.ns7.x86_64.rpm x86_64

@gsanchietti gsanchietti merged commit 490d1a4 into master Nov 25, 2024
1 check passed
@gsanchietti gsanchietti deleted the sdl-7103 branch November 25, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants