Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ns7admin for migration #79

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Use ns7admin for migration #79

merged 2 commits into from
Sep 4, 2024

Conversation

stephdl
Copy link
Contributor

@stephdl stephdl commented Aug 13, 2024

The ns8-join script has been updated to check for an existing user before joining and to create the ns7admin user and handle failure gracefully. The ns8-leave script has been updated to remove the ns7admin user when leaving the cluster. These changes ensure that the scripts function correctly and improve the overall stability of the system.

NethServer/dev#6994

@nethbot
Copy link
Member

nethbot commented Aug 13, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.3.pr79.g99ac25d.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Aug 13, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.3.pr79.g722fd6c.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Aug 13, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.3.pr79.gdc104e7.ns7.x86_64.rpm x86_64

@@ -29,6 +29,7 @@ if [[ -n "${USER_DOMAIN}" ]] && [[ -z "${ACCOUNT_PROVIDER_EXTERNAL}" ]]; then
fi

if [[ -n "${NODE_ID}" ]]; then
ns8-action --detach cluster remove-user '{"user": "ns7admin"}' || :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to execute this command after the next one.

Every ns8-action call does a login: if the user is removed, the next call may fail. I consider remove-node more important than remove-user (which can be removed manually later).

root/usr/sbin/ns8-join Outdated Show resolved Hide resolved
@nethbot
Copy link
Member

nethbot commented Sep 4, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.4.pr79.g2849410.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Sep 4, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.5.pr79.gbe3ecab.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Sep 4, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.7.pr79.gb970f83.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Sep 4, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.8.pr79.g0ac099d.ns7.x86_64.rpm x86_64

@nethbot
Copy link
Member

nethbot commented Sep 4, 2024

in 7.9.2009/autobuild:

  • nethserver-ns8-migration-1.0.15-1.2.pr79.gad2d0ad.ns7.x86_64.rpm x86_64

Copy link
Member

@DavidePrincipi DavidePrincipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephdl stephdl merged commit d55181d into master Sep 4, 2024
1 check passed
@stephdl stephdl deleted the sdl-6994 branch September 4, 2024 15:34
@stephdl stephdl restored the sdl-6994 branch September 4, 2024 15:34
@stephdl stephdl deleted the sdl-6994 branch September 4, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants