-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ns7admin for migration #79
Conversation
in
|
in
|
in
|
root/usr/sbin/ns8-leave
Outdated
@@ -29,6 +29,7 @@ if [[ -n "${USER_DOMAIN}" ]] && [[ -z "${ACCOUNT_PROVIDER_EXTERNAL}" ]]; then | |||
fi | |||
|
|||
if [[ -n "${NODE_ID}" ]]; then | |||
ns8-action --detach cluster remove-user '{"user": "ns7admin"}' || : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please try to execute this command after the next one.
Every ns8-action call does a login: if the user is removed, the next call may fail. I consider remove-node more important than remove-user (which can be removed manually later).
in
|
in
|
in
|
in
|
in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The ns8-join script has been updated to check for an existing user before joining and to create the ns7admin user and handle failure gracefully. The ns8-leave script has been updated to remove the ns7admin user when leaving the cluster. These changes ensure that the scripts function correctly and improve the overall stability of the system.
NethServer/dev#6994