remove netflix commons #519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * limitations under the License. | ||
| * | ||
| */ | ||
| package com.netflix.stats.distribution; |
There was a problem hiding this comment.
Having the same classes here and in netflix-common libs could create problems if both wind up in the classpath. Could the package be changed to avoid possible conflicts?
There was a problem hiding this comment.
That's a good idea, hopefully no one is using netflix-commons directly
There was a problem hiding this comment.
Move to a package prefixed with internal., open to naming of course
joshgord
force-pushed
the
josh/commons
branch
from
4048d8e
to
0ebec31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forklift what we use out of netflix commons and remove the dependency. For whatever reason it looks like commons has fallen into disrepair and doesn't appear to be actively maintained