Fixing "Link arrows way too big in some cases" #298 #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
I don't think that it's a good solution to this problem to change only the coefficients of scaling. I've commented on #298 with my thoughts on this, but, for example, here's a picture of Link Breeds Example (for comparison with the others), using the scaling values from your PR:
The indicators are smaller, yes, but the down-scaling has caused them to look jaggy and unpleasant. It's not apparent to me that these indicators are ultimately better than the ones we currently have or closer to how we want them to look. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for the link arrows too big. I am still working on it to make the arrows better. However these changes fix the issue mentioned in #298.