-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: social login exchange token #332
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
- Coverage 77.26% 76.21% -1.05%
==========================================
Files 4 4
Lines 2261 1972 -289
==========================================
- Hits 1747 1503 -244
+ Misses 345 329 -16
+ Partials 169 140 -29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :)
A new tag will be released, as I merge the other PRs
Thanks Pak @Nerzal 😊 |
hmn something seems to be broken in the tests now, not sure if related to the PR itself. |
I think the problem is in the token, because it's expired Pak @Nerzal NB: i used Oauth2 Google |
Guess we can't put static tokens into the tests, as the pipelines and local tests are going to fail if we do that |
Can you please finish this merge request? Really need "subject_issuer" for proper token exchange. Thanks! |
I cannot merge this merge request as is. |
fix(go): add accept-charset utf-8
Hi @Nerzal ,
I added a social login exchange token