Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature sensors #38

Merged
merged 12 commits into from
Jun 24, 2024
Merged

Temperature sensors #38

merged 12 commits into from
Jun 24, 2024

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Jun 21, 2024

The large number of minor changes are the result of applying ufmt to organize the imports that the top of each module, and the application of pylint to tidy up a variety of code structures.

Added

  • image_records.py - Added ccu_temperature and external_temperature columns to record the
    AD590 sensor data.

Fixed

  • get_position.py - The get_position_and_pose functions now have an explicit timeout
    and throw exceptions if they have difficulties with their connection.

Changed

  • requirements.txt - Added version number requirements that reflect the current testing
    environment.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the vipersci project uses, and I have submitted a CLA.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 80.89888% with 34 lines in your changes missing coverage. Please review.

Project coverage is 72.17%. Comparing base (5345932) to head (9ec3a87).

Files Patch % Lines
src/vipersci/vis/pds/create_browse.py 0.00% 9 Missing ⚠️
src/vipersci/carto/get_position.py 0.00% 8 Missing ⚠️
src/vipersci/carto/dice_buffer.py 0.00% 4 Missing ⚠️
src/vipersci/vis/db/image_records.py 84.61% 4 Missing ⚠️
src/vipersci/carto/accrual.py 0.00% 2 Missing ⚠️
src/vipersci/vis/viseer.py 0.00% 2 Missing ⚠️
src/vipersci/carto/colorforge.py 75.00% 1 Missing ⚠️
src/vipersci/vis/anom_pixel.py 0.00% 1 Missing ⚠️
src/vipersci/vis/create_mmgis_pano.py 85.71% 1 Missing ⚠️
src/vipersci/vis/create_pano.py 87.50% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   72.32%   72.17%   -0.16%     
==========================================
  Files          58       58              
  Lines        3411     3396      -15     
==========================================
- Hits         2467     2451      -16     
- Misses        944      945       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer rbeyer merged commit e0a5add into main Jun 24, 2024
7 of 8 checks passed
@rbeyer rbeyer deleted the temperature_sensors branch June 24, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant