Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better name handling and Pano thumbnails #33

Merged
merged 5 commits into from
Feb 21, 2024
Merged

Better name handling and Pano thumbnails #33

merged 5 commits into from
Feb 21, 2024

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Feb 19, 2024

  • The instrument_name() function in pid.py now can deal with alias names that are within a given string, not just an exact match.
  • Now that pid.instrument_name() is more robust, ImageRecord.init() can handle a wider variety of Yamcs parameter names, should they change in the future.
  • create_mmgis_pano.py - create() now takes a thumbsize int or tuple of ints that will control the creation and size of an output thumbnail JPG file, with naming convention set by Yamcs/OpenMCT.

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the vipersci project uses, and I have submitted a CLA.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (e27bc87) 66.88% compared to head (1509546) 68.29%.

Files Patch % Lines
src/vipersci/vis/create_mmgis_pano.py 0.00% 21 Missing ⚠️
src/vipersci/vis/db/image_records.py 93.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   66.88%   68.29%   +1.41%     
==========================================
  Files          58       58              
  Lines        3343     3375      +32     
==========================================
+ Hits         2236     2305      +69     
+ Misses       1107     1070      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer
Copy link
Member Author

rbeyer commented Feb 21, 2024

Also decided to upgrade pid.py and image_records.py to deal with new icer_byte_quota and icer_minloss values.

@rbeyer rbeyer merged commit de8a373 into main Feb 21, 2024
8 checks passed
@rbeyer rbeyer deleted the vis_names branch February 21, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant