Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intent and verification #28

Merged
merged 8 commits into from
Sep 21, 2023
Merged

Intent and verification #28

merged 8 commits into from
Sep 21, 2023

Conversation

rbeyer
Copy link
Member

@rbeyer rbeyer commented Sep 15, 2023

Added a variety of table definitions to support intent (image_request.py) and verification (ldst_verification.py and new columns to image_record.py). Also created a nascent image_tags.py table, and built the many-to-many connections between the ldst table and the image_requests table.

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing:

This project is released under the LICENSE.

  • I claim copyrights on my contributions in this pull request, and I provide those contributions via this pull request under the same license terms that the vipersci project uses, and I have submitted a CLA.

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch coverage: 87.09% and project coverage change: +1.47% 🎉

Comparison is base (e5ec3a2) 66.08% compared to head (c0dec2d) 67.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   66.08%   67.55%   +1.47%     
==========================================
  Files          38       44       +6     
  Lines        2282     2466     +184     
==========================================
+ Hits         1508     1666     +158     
- Misses        774      800      +26     
Files Changed Coverage Δ
src/vipersci/vis/db/create_vis_dbs.py 65.07% <43.58%> (-34.93%) ⬇️
src/vipersci/vis/db/image_requests.py 97.43% <97.43%> (ø)
src/vipersci/vis/db/image_records.py 90.53% <100.00%> (+0.25%) ⬆️
src/vipersci/vis/db/image_tags.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/junc_image_record_tags.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/junc_image_req_ldst.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/ldst.py 100.00% <100.00%> (ø)
src/vipersci/vis/db/ldst_verification.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rbeyer rbeyer merged commit 3754458 into main Sep 21, 2023
9 checks passed
@rbeyer rbeyer deleted the intent_and_verification branch September 21, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant