Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UnivPoly adhoc subtraction #1881

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

lgoettgens
Copy link
Collaborator

Cherry-picked from #1867.

@lgoettgens lgoettgens enabled auto-merge (squash) October 29, 2024 14:03
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.13%. Comparing base (193e1b8) to head (278d78d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/generic/UnivPoly.jl 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1881      +/-   ##
==========================================
- Coverage   88.13%   88.13%   -0.01%     
==========================================
  Files         120      120              
  Lines       30278    30282       +4     
==========================================
+ Hits        26687    26689       +2     
- Misses       3591     3593       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator Author

lgoettgens commented Oct 29, 2024

@benlorenz https://github.com/Nemocas/AbstractAlgebra.jl/actions/runs/11575515402/job/32222361228 is another instance where vinberg_2 needs more time than usual. (I restarted the job after about 30 min in this one testfile)

@lgoettgens lgoettgens merged commit 45bd09a into Nemocas:master Oct 29, 2024
27 of 29 checks passed
@lgoettgens lgoettgens deleted the lg/univpoly-sub branch October 29, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants