Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some internal functions #1679

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

@lgoettgens
Copy link
Collaborator

Even though these are internal, I think they can create confusion with the new is_terse and terse functions introduced in #1677. What about renaming these here to set_terse_level or something to make clear that they reason about :terse_level and not :terse?

@fingolfin
Copy link
Member Author

I don't think the potential for confusion is that high. But anyway, I've removed those functions completely.

@fingolfin fingolfin changed the title Rename some internal functions Remove some internal functions Apr 19, 2024
Copy link
Collaborator

@lgoettgens lgoettgens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.92%. Comparing base (99ef240) to head (17878da).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1679      +/-   ##
==========================================
- Coverage   86.92%   86.92%   -0.01%     
==========================================
  Files         116      116              
  Lines       29622    29618       -4     
==========================================
- Hits        25750    25746       -4     
  Misses       3872     3872              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgoettgens
Copy link
Collaborator

The two failures in OscarCI-matching are Nemocas/Nemo.jl#1722. OscarCI-release had some garbage collection issue and I restarted.

@fingolfin fingolfin merged commit 5d5c1de into Nemocas:master Apr 19, 2024
28 of 31 checks passed
@fingolfin fingolfin deleted the mh/rename-internal branch April 19, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants