Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request #43

Open
wants to merge 197 commits into
base: add-license-1
Choose a base branch
from
Open

request #43

wants to merge 197 commits into from

Conversation

KenSoltes
Copy link

pull request

…y address and delivery address list and item category layout !
… and added create your shop list item.

and refinements in empty screens and offline indication.
The error was only visible when generating a signed apk / bundle !
@gitguardian
Copy link

gitguardian bot commented Sep 28, 2022

⚠️ GitGuardian has uncovered 17 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
- Google API Key d217cfd app/src/main/AndroidManifest.xml View secret
- Google API Key d217cfd app/src/main/java/org/nearbyshops/enduserappnew/MyApplication.java View secret
- Google API Key 6ece5de app/src/main/AndroidManifest.xml View secret
- Google API Key 6ece5de app/src/main/java/org/nearbyshops/enduserappnew/MyApplication.java View secret
- Google API Key 6ece5de app/src/main/res/values/custom_settings.xml View secret
- Google API Key 2371406 app/src/main/res/values/custom_settings.xml View secret
- Google API Key 2371406 app/src/main/res/values/custom_settings.xml View secret
- Google API Key 01baeb6 app/src/main/res/values/custom_settings.xml View secret
- Google API Key 76de381 app/src/main/res/values/custom_settings.xml View secret
- Google API Key a46bcfd app/src/main/res/values/custom_settings.xml View secret
1635909 Google API Key 54ac6c8 app/src/main/res/values/custom_settings.xml View secret
1635910 Google API Key 54ac6c8 app/src/main/res/values/custom_settings.xml View secret
1635909 Google API Key 7ddbb79 app/src/main/res/values/custom_settings.xml View secret
1635910 Google API Key 7ddbb79 app/src/main/res/values/custom_settings.xml View secret
1635909 Google API Key fb00b4b app/src/main/res/values/custom_settings.xml View secret
1635910 Google API Key fb00b4b app/src/main/res/values/custom_settings.xml View secret
1635910 Google API Key 0a22c85 app/src/main/res/values/custom_settings.xml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants