-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android number format #24
base: master
Are you sure you want to change the base?
Conversation
It seems that the currency should be set on the DecimalFormatSymbols instance before setting it to the NumberFormat instance in order to display proper currency.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign the CLA at https://www.nativescript.org/cla. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Co-authored-by: hiperbou <[email protected]>
@NathanWalker can you merge this PR please? thx |
(perf) move instance creation to the constructor. (feat) expose native formatter instance. (fix) merge NativeScript#24
It seems that the currency should be set on the DecimalFormatSymbols instance before setting it to the NumberFormat instance in order to display proper currency.
With the old implementation, we had the following results, from which the first is ok, but the second is wrong:
And with the new one, the second call results in
BGN123.90
which seems to be the correct result.Fixes #23