Docs for settings #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for NativePHP/laravel#432 and NativePHP/electron#141
On less task for: NativePHP/laravel#364
I understand you prefer not to include Electron-specific details due to the upcoming Tauri driver, but I thought someone might need them for debugging purposes. I added a note indicating that settings are stored in
config.json, as mentioned in the package documentation sindresorhus/electron-store.I also looked for the equivalent package in Tauri, which is harshkhandeparkar/tauri-settings. They replicate everything from tauri-settings but use
settings.jsonfor the filename, which is configurable.I believe the usefulness of those dependencies is debatable. It would only take a few lines in Laravel to write directly to the file. The current method's only advantage is the potential to implement a reactive JavaScript facade, such as with AlpineJS. For now, this approach is acceptable. I'm not trying to start a debate at this moment; we can discuss those details later. I just thought it was worth noting somewhere.