Fix config commands not registered #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues with a specified `void` return type.
…d` to the package's service provider configuration.
|
I believe the underlying issue that was causing this has been resolved, so I think this PR can probably be closed. Can you confirm @david-d-h? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two tiny things, one of them being that values were being returned inside of the
MinifyApplicationCommand::deleteDirectoryRecursivemethod.And the other issue being one that is described in #168 and #160, this PR registers the
LoadStartupConfigurationCommandandLoadPHPConfigurationCommandcommands in the service provider'sconfigurePackagemethod instead of dynamically resolving them later.(These commands do get registered it seems, but they don't get registered on time. I assume this command is ran internally while they are not yet registered.)
Closes #168