Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows php path for native:minify #111

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

kritish-dhaubanjar
Copy link
Contributor

@kritish-dhaubanjar kritish-dhaubanjar commented Oct 12, 2024

Description

In windows, php is getting resolved as C:\Users\virtualbox\Downloads\laravel\api\vendor\nativephp\electron\\resources\js\php.js instead of system php.exe.

Example:

> where php results in 2 php executables php.js and php.exe relative to resources/js/electron-builder.js. This is causing a fail in the windows build during php artisan native:minify step

image

Resolves

@kritish-dhaubanjar kritish-dhaubanjar changed the title fix windows php path for native:minify Fix windows php path for native:minify Oct 12, 2024
@kritish-dhaubanjar
Copy link
Contributor Author

@simonhamp, Is there something I can improve on this fix? Thanks!

@simonhamp
Copy link
Member

simonhamp commented Oct 26, 2024

I think we should get rid of this minify command altogether tbh

@kritish-dhaubanjar
Copy link
Contributor Author

kritish-dhaubanjar commented Oct 26, 2024

@simonhamp, Would it be okay to remove it in this in this PR?

@simonhamp
Copy link
Member

Yeh go for it

@simonhamp simonhamp merged commit 56db7fc into NativePHP:main Nov 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants