DAS sampling without data column retrieving #174
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As described in #123 we need not retrieve a column from DB when sampling, we just need to make sure it exist in DB
For this a new method was added to
DataColumnSidecarCustody
:It now still does a DB query for every request, but that will be heavily optimized with a DB column indexes cache in the next PR. (the similar is not viable for the
getCustodyDataColumnSidecar
method)AvailabilityChecker<DataColumnSidecar>
has been changed toAvailabilityChecker<UInt64>
. However there is no much sense in returning column indexes. It was just made to accomodate the existing APIFixed Issue(s)
Fix #123
Documentation
doc-change-required
label to this PR if updates are required.Changelog