Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAS sampling without data column retrieving #174

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

Nashatyrev
Copy link
Owner

@Nashatyrev Nashatyrev commented Oct 25, 2024

PR Description

As described in #123 we need not retrieve a column from DB when sampling, we just need to make sure it exist in DB

For this a new method was added to DataColumnSidecarCustody:

SafeFuture<Boolean> hasCustodyDataColumnSidecar(DataColumnSlotAndIdentifier columnId);

It now still does a DB query for every request, but that will be heavily optimized with a DB column indexes cache in the next PR. (the similar is not viable for the getCustodyDataColumnSidecar method)

AvailabilityChecker<DataColumnSidecar> has been changed to AvailabilityChecker<UInt64>. However there is no much sense in returning column indexes. It was just made to accomodate the existing API

Fixed Issue(s)

Fix #123

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@Nashatyrev
Copy link
Owner Author

Agreed on post-merge review with @zilm13

@Nashatyrev Nashatyrev merged commit d26aefe into das Oct 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant