Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Actions #482

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

ArangoGutierrez
Copy link
Collaborator

No description provided.

@ArangoGutierrez ArangoGutierrez force-pushed the githubactions branch 2 times, most recently from 997a082 to 12a4c65 Compare January 27, 2024 14:10
@ArangoGutierrez ArangoGutierrez self-assigned this Jan 27, 2024
@ArangoGutierrez ArangoGutierrez force-pushed the githubactions branch 4 times, most recently from 106b5ee to 4b04938 Compare January 27, 2024 16:00
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ArangoGutierrez

I think there are multiple tasks captured in this PR. It may make sense to submit some of them -- e.g. updating the dockerfiles and makefile to use k8s-test-infra -- separately so that this could be focussed on adding the actions.

.github/workflows/image_post.yaml Outdated Show resolved Hide resolved
.github/workflows/image_post.yaml Outdated Show resolved Hide resolved
.github/workflows/image_post.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
deployments/container/Dockerfile.ubi8 Outdated Show resolved Hide resolved
deployments/container/Dockerfile.ubi8 Outdated Show resolved Hide resolved
deployments/container/Dockerfile.ubi8 Outdated Show resolved Hide resolved
versions.mk Show resolved Hide resolved
Makefile Show resolved Hide resolved
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments regaring split image workflow.

.github/workflows/image_post.yaml Outdated Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

I have consumed the changes of #483 into this PR

Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments. No blockers though.

.github/workflows/golang.yaml Outdated Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
.common-ci.yml Outdated Show resolved Hide resolved
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One issue in the action spec.

.github/issue_template.md Outdated Show resolved Hide resolved
.github/workflows/image.yaml Outdated Show resolved Hide resolved
ArangoGutierrez and others added 5 commits January 28, 2024 16:04
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ArangoGutierrez ArangoGutierrez merged commit e904c48 into NVIDIA:main Jan 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants