-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Support fancy iterators in cuda.parallel #2788
Draft
rwgk
wants to merge
103
commits into
NVIDIA:main
Choose a base branch
from
rwgk:fancy_iterators
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+686
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rators.py (with unit tests).
…el_itertools branch. The other branch is: https://github.com/rwgk/cccl/tree/cuda_parallel_itertools
…to see if numba can still compile it).
…t then fails with: Fatal Python error: Floating point exception
…resolves the Floating point exception (but the `cccl_device_reduce()` call still does not succeed)
LOOOK single_tile_kernel CALL /home/coder/cccl/c/parallel/src/reduce.cu:116 LOOOK EXCEPTION CUDA error: invalid argument /home/coder/cccl/c/parallel/src/reduce.cu:703
…rametrize: `use_numpy_array`: `[True, False]`, `input_generator`: `["constant", "counting", "arbitrary", "nested"]`
…iterators.py (because numba.cuda cannot JIT classes).
… `unary_op`, which is then compiled with `numba.cuda.compile()`
… the `"map_mul2"` test and the added `"map_add10_map_mul2"` test works, too.
…s_iterators branch.
🟩 CI finished in 1h 46m: Pass: 100%/3 | Total: 29m 09s | Avg: 9m 43s | Max: 19m 58s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
🏃 Runner counts (total jobs: 3)
# | Runner |
---|---|
2 | linux-amd64-gpu-v100-latest-1 |
1 | linux-amd64-cpu16 |
…ncy with all other iterator types.
🟩 CI finished in 44m 00s: Pass: 100%/3 | Total: 31m 08s | Avg: 10m 22s | Max: 20m 33s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
🏃 Runner counts (total jobs: 3)
# | Runner |
---|---|
2 | linux-amd64-gpu-v100-latest-1 |
1 | linux-amd64-cpu16 |
…ntingIterator. This fixes the counting_float32, counting_float64 tests.
🟨 CI finished in 1h 32m: Pass: 66%/3 | Total: 24m 37s | Avg: 8m 12s | Max: 18m 38s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
🏃 Runner counts (total jobs: 3)
# | Runner |
---|---|
2 | linux-amd64-gpu-v100-latest-1 |
1 | linux-amd64-cpu16 |
…UMBA_TYPE, _DISTANCE_IR_TYPE. Resolve most TODOs.
… map_mul2_float32_int32 does not pass (commented out in this commit).
… _CHAR_PTR_IR_TYPE
…e_codegen()" This reverts commit b525b80.
…separately, or when running all tests in parallel (pytest -v -n 32).
…t_float64_float32_int16 tests. map_mul* tests are flaky,TBD why.
rwgk
force-pushed
the
fancy_iterators
branch
from
November 23, 2024 01:59
49aef45
to
79a6dac
Compare
🟨 CI finished in 20m 34s: Pass: 66%/3 | Total: 29m 18s | Avg: 9m 46s | Max: 19m 11s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
🏃 Runner counts (total jobs: 3)
# | Runner |
---|---|
2 | linux-amd64-gpu-v100-latest-1 |
1 | linux-amd64-cpu16 |
…, I cannot explain why/how).
🟩 CI finished in 1h 56m: Pass: 100%/3 | Total: 30m 23s | Avg: 10m 07s | Max: 19m 31s
|
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
Modifications in project or dependencies?
Project | |
---|---|
CCCL Infrastructure | |
libcu++ | |
CUB | |
Thrust | |
CUDA Experimental | |
+/- | python |
+/- | CCCL C Parallel Library |
Catch2Helper |
🏃 Runner counts (total jobs: 3)
# | Runner |
---|---|
2 | linux-amd64-gpu-v100-latest-1 |
1 | linux-amd64-cpu16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #2479
WORK IN PROGRESS
See #2479 for context.