Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for resiliency feature integration #11406

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

maanug-nv
Copy link
Collaborator

What does this PR do ?

Add back tests that were originally in #11117

Collection: [llm]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

ShriyaPalsamudram and others added 30 commits November 15, 2024 04:58
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: Shriya Balaji Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
ShriyaPalsamudram and others added 10 commits November 15, 2024 04:58
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: Shriya Palsamudram <[email protected]>
Signed-off-by: ShriyaPalsamudram <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
Signed-off-by: Maanu Grover <[email protected]>
Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.lightning.run.plugins
nemo/lightning/run/plugins.py:80:0: C0301: Line too long (145/119) (line-too-long)
nemo/lightning/run/plugins.py:91:0: C0301: Line too long (201/119) (line-too-long)
nemo/lightning/run/plugins.py:96:0: C0301: Line too long (200/119) (line-too-long)
nemo/lightning/run/plugins.py:97:0: C0301: Line too long (127/119) (line-too-long)
nemo/lightning/run/plugins.py:181:0: C0301: Line too long (174/119) (line-too-long)
nemo/lightning/run/plugins.py:257:0: C0301: Line too long (150/119) (line-too-long)
nemo/lightning/run/plugins.py:70:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:159:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:204:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/run/plugins.py:267:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.19/10

Thank you for improving NeMo's documentation!

Copy link
Contributor

[🤖]: Hi @maanug-nv 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants