Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial attempt at extracting certain frames from the main window #297

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vshekar
Copy link
Collaborator

@vshekar vshekar commented May 26, 2023

This is a first attempt at removing the definition of certain parts of the acquisition frame and moving it to their own files.
This kind of modularization will allow another beamline to inherit, pick and choose what it wants to modify by class.

This pull request consists of extracting the following frames

  • Vector Params
  • MultiCol params
  • Characterize params
  • Raster params
  • Processing options params

@JunAishima
Copy link
Collaborator

do you mean that they would modify certain classes in a particular file instead of modifying control_main as a whole?
this brings up the issue of how forking LSDC affects deployment. if we do end up packaging LSDC into a pypi package -> conda package, a fork would have to have an entirely different pipeline, from pypi to conda package to conda environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants