Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precursor m/z value fix #283

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Precursor m/z value fix #283

merged 3 commits into from
Nov 26, 2024

Conversation

liannette
Copy link
Contributor

Fix #282

Major changes:

  • load correct precursor m/z values from MGF file
  • add precursor charge as Spectrum attribute

@liannette liannette changed the title Mz mass fix Precursor m/z value fix Nov 5, 2024
@liannette liannette marked this pull request as ready for review November 5, 2024 15:42
@liannette
Copy link
Contributor Author

@CunliangGeng I would like to add you as reviewer

@justinjjvanderhooft
Copy link

@liannette I just did (Cunliang is on holidays till next week Wednesday)

Copy link
Member

@CunliangGeng CunliangGeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :shipit: Please check my comments and merge it. Let me know if you don't have permissions to merge.

@liannette
Copy link
Contributor Author

I added the comment, can you merge it? I don't have the permissions

@justinjjvanderhooft
Copy link

Thanks @liannette! @CunliangGeng you may do the magic! 😜

@CunliangGeng CunliangGeng merged commit 53f906f into NPLinker:dev Nov 26, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Incorrect precursor m/z when loading MGF file from GNPS
3 participants