Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding HYDRUS soils params #35

Merged
merged 1 commit into from
Sep 13, 2024
Merged

adding HYDRUS soils params #35

merged 1 commit into from
Sep 13, 2024

Conversation

peterlafollette
Copy link
Contributor

@peterlafollette peterlafollette commented Sep 13, 2024 •
edited
Loading

[Short description explaining the high-level reason for the pull request]

Additions

Added a .dat file where soils occur in the same order and same format as in vG_params_stat_nom_ordered.dat, but now with data from the HYDRUS soils catalog

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

ajkhattak
ajkhattak approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@ajkhattak ajkhattak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@ajkhattak ajkhattak merged commit fe0f224 into master Sep 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajkhattak ajkhattak ajkhattak approved these changes

@hellkite500 hellkite500 Awaiting requested review from hellkite500

@aaraney aaraney Awaiting requested review from aaraney

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterlafollette @ajkhattak