Merge the RadMon data extract source code into rrfs_util. #46
Conversation
xyzemc
requested review from
christinaholtNOAA,
christopherwharrop-noaa,
chunhuazhou,
daviddowellNOAA,
guoqing-noaa and
hu5970
as code owners
There was a problem hiding this comment.
There is a lot of duplication in this pull request. The specification of compiler flags for different compilers should ideally be done in one place for the entire repository, not duplicated verbatim in multiple places. Additionally, the introduction of multiple kinds.f90 creates unnecessary duplication, particularly since rrfs_utls already has a kinds module. Please remove duplication and make use of existing code and build specifications where possible.
|
@christopherwharrop-noaa This repository is to host many small applications for RRFS. Some of those applications are isolated from others. I agree it is good to reduce the duplication. We also need to check this case by case. "kind.f90" used here may not have the same definition as the kinds module used by other. Do we have a way to keep some code used locally (like kinds.f90 only used by this application)? The same possible is also applying for compiling options. |
|
@christopherwharrop-noaa @hu5970 I will compare the kind.f90 in this PR and the existing kind.f90 in rrfs_util to see if they are same and can avoid the duplication. |
… a seperate directory. Modified the CMake file to generate three module (.mod) in the include directory.
|
@xyzemc Please remove save directory and sync with current develop branch. |
There was a problem hiding this comment.
Thank you for taking the time to address my comments. This looks great! There are a couple commented lines in CMakeLists.txt files that should be removed, and you might also consider removing what look like (I'm not sure) commented out debugging write statements. Once the Cmake comments are removed, I'll approve.
Modified the kinds.mod to kinds_radmon.mod in share/kinds_radmon.F90. Modified the 'use kinds' to 'use kinds_radmon'
#43
The RadMon (radiance monitoring) package is used to extract data from
radiance diagnostic files to generate the binary files for plotting the statistics from radiance data assimilation, and generate tons of images for each satellite instrument and channel. It has been used in GDAS and NAM DA operational.
This pull request is for adding the RadMon source code into rrfs_util.
The data extract step from RadMon include four packs of source code:
verf_radang.fd/
verf_radbcoef.fd/
verf_radbcor.fd/
verf_radtime.fd/
All these codes have put in the directory 'radmon' under rrfs_util. The corresponding makefile has been modified and tested. Four executables will be placed into the ./bin directory as all other code did.