Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#216 Fix compile log and change some format to f-strings #275

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

singhd789
Copy link
Collaborator

Describe your changes

Issue ticket number and link (if applicable)

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback

@singhd789
Copy link
Collaborator Author

thanks @ilaflott for pointing me in the right direction of subprocess.Popen!

Copy link

@uramirez8707 uramirez8707 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close!
This is the error message I am getting for a failed compile

There was an error running {self.bld}/compile.sh
Check the log file: /ncrc/home1/Uriel.Ramirez/fremake_canopy/test/am5f7c1r0_om5_b06_compile/ncrc5.intel23-prod-openmp/exec/log.compile

The log.compile file is being created now.

p2.communicate()

if p1.returncode != 0:
print("\nThere was an error running {self.bld}/compile.sh")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be something like

print("\nThere was an error running " + self.bld + " /compile.sh")

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooop, thanks! Forgot the f in the f-print statement. I'll fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants