-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update esm4p2 and null model yamls for c5 update #270
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this Ryan! I just have a few clarifying questions. Also, do you think we should keep JUST the null model example in here for testing, and move the AM5 and ESM4p2 completely over to fre-examples? I think this would make it slightly less convoluted here.
Yeah I think thats a great idea, I'll remove the directories with this PR and make a new one to fre-examples. |
@singhd789 I think a couple tests use the am5.yaml so this will break the testing. Maybe we should keep those around for now, unless we want to go crazy and add another git submodule for the fre-examples repo lol. |
Oh interesting. I think you may be right (fre cli make tests maybe). Now I'm wondering how the checks passed without those. We can keep the AM5 yamls in for now if needed (we should change those to use the null model). Good catch! |
ca83978
to
26956ba
Compare
Describe your changes
just updates the esm4p2 and null model example yamls to work with the latest c5 modules
Checklist before requesting a review