Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerized CI and added reusable workflow capability #19

Merged
merged 29 commits into from
Jun 27, 2024

Conversation

mlee03
Copy link
Contributor

@mlee03 mlee03 commented Jun 11, 2024

Description
In this PR, the CI workflow is changed to run in a container. The container is built from a base miniforge container. GNU compilers, netCDF and HDF5 libraries, and MPICH have been installed. The default python version is set to 3.11.7.

The workflow yaml file has also been edited to allow reusable workflows. PySHiELD translate tests can now be triggered from PyFV3 and NDSL repositories.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

fmalatino
fmalatino previously approved these changes Jun 18, 2024
Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

xyuan
xyuan previously approved these changes Jun 21, 2024
oelbert
oelbert previously approved these changes Jun 21, 2024
Copy link
Collaborator

@oelbert oelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlee03 mlee03 dismissed stale reviews from oelbert, xyuan, and fmalatino via 9601463 June 21, 2024 21:47
@mlee03 mlee03 changed the title Containerized CI Containerized CI and added reusable workflow capability Jun 21, 2024
@mlee03
Copy link
Contributor Author

mlee03 commented Jun 21, 2024

Sorry! I pushed to the reusable workflow changes to the wrong branch and now it's in this branch. It should work! I think this PR needs to be re-approved.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

numpy needs to be pinned to 1.26.4, then should be good to merge

@mlee03
Copy link
Contributor Author

mlee03 commented Jun 25, 2024

Following your suggestion, it has been changed.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also appears that the lint process will now require a python 3.11.7 base as well. Then it should be good to merge.

Copy link
Contributor

@fmalatino fmalatino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@fmalatino fmalatino merged commit 693014f into NOAA-GFDL:develop Jun 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants