Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/driver test #10

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Conversation

oelbert
Copy link
Collaborator

@oelbert oelbert commented Feb 16, 2024

Description
Fixes GFS driver translate test so it can be run as part of CI.

  • pySHiELD/_config.py: Add dycore_only to the physics config
  • tests/savepoint/translate/__init__.py Added GFSPhysicsDriver to test regime
  • tests/savepoint/translate/translate_gfs_physics_driver.py Passes namelist through physics config class, which is how it should work anyway

Fixes # 9
Fixes

How Has This Been Tested?
Savepoint tests have been run

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • New check tests, if applicable, are included
  • Targeted model, if this change was triggered by a model need/shortcoming

@oelbert oelbert marked this pull request as draft March 4, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant