-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GCC 12 & 14 to CI testing #254
Merged
AlysonStahl-NOAA
merged 9 commits into
NOAA-EMC:develop
from
AlexanderRichert-NOAA:gcc_testing_oct24
Oct 4, 2024
Merged
Add GCC 12 & 14 to CI testing #254
AlysonStahl-NOAA
merged 9 commits into
NOAA-EMC:develop
from
AlexanderRichert-NOAA:gcc_testing_oct24
Oct 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderRichert-NOAA
requested review from
AlysonStahl-NOAA and
edwardhartnett
October 1, 2024 19:35
Once approved I'll update required tests |
edwardhartnett
approved these changes
Oct 2, 2024
AlysonStahl-NOAA
approved these changes
Oct 2, 2024
@AlexanderRichert-NOAA do you want to do more work on this or is it ready to merge? |
No this is good to go, I just removed the two required tests in the branch settings. |
|
||
strategy: | ||
# fail-fast: true | ||
matrix: | ||
config: | ||
- { | ||
options: "-DUSE_IPOLATES=ON" | ||
options: "-DUSE_IPOLATES=ON -DBLA_VENDOR=OpenBLAS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this new option come from?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds GCC 12 & 14 to Linux_options.yml. It runs the main 5 jobs with GCC 12, and runs an additional, option-less job with GCC 14.
The
CFLAGS="-Wno-implicit-function-declaration -Wno-incompatible-pointer-types"
for jasper seems to be needed for GCC 14. I have not investigated it any further.squash-n-merge