Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCC 12 & 14 to CI testing #254

Merged

Conversation

AlexanderRichert-NOAA
Copy link
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA commented Oct 1, 2024

This PR adds GCC 12 & 14 to Linux_options.yml. It runs the main 5 jobs with GCC 12, and runs an additional, option-less job with GCC 14.

The CFLAGS="-Wno-implicit-function-declaration -Wno-incompatible-pointer-types" for jasper seems to be needed for GCC 14. I have not investigated it any further.

squash-n-merge

@AlexanderRichert-NOAA
Copy link
Contributor Author

Once approved I'll update required tests

@AlexanderRichert-NOAA AlexanderRichert-NOAA marked this pull request as ready for review October 1, 2024 19:36
@edwardhartnett
Copy link
Contributor

@AlexanderRichert-NOAA do you want to do more work on this or is it ready to merge?

@AlexanderRichert-NOAA
Copy link
Contributor Author

No this is good to go, I just removed the two required tests in the branch settings.

@AlysonStahl-NOAA AlysonStahl-NOAA merged commit d927ec9 into NOAA-EMC:develop Oct 4, 2024
10 checks passed

strategy:
# fail-fast: true
matrix:
config:
- {
options: "-DUSE_IPOLATES=ON"
options: "-DUSE_IPOLATES=ON -DBLA_VENDOR=OpenBLAS"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did this new option come from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants