Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update task names in ecflow workflow #544

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

BenjaminBlake-NOAA
Copy link
Contributor

@BenjaminBlake-NOAA BenjaminBlake-NOAA commented Nov 6, 2024

DESCRIPTION OF CHANGES:

  • This PR updates the ecflow workflow to the updated task names in the main branch of rrfs-workflow. The current version of ecflow files in the main branch will not work without these updates. These task name changes were made as part of PR [production/RRFS.v1] Update task names for forecast, post, and prdgen tasks #421 and PR [production/RRFS.v1] Update DA task names in workflow, cleanup modulefiles #424 . I apologize that this PR is a little overwhelming to review with such a large number of changed files. I've summarized the changes here:
    • ecf/defs: The task names within the ecflow definition files have been updated.
    • ecf/include: The file names of the .h files in this directory have been updated to match the new task names.
    • ecf/scripts: Some of the files in this directory are renamed to match the updated task names. Changes were also made within the scripts to point to the correct J-jobs and modulefiles, and some resource settings were updated to match what is used in the real-time parallel.
    • scripts/exrrfs_fsm.sh: The trigger names are updated to match the new task names.
  • Here are some of the updated task names (I might be missing some of these):
    • analysis_gsi_input -> analysis_gsi
    • bufr -> process_bufr
    • cldanl_nonvar -> analysis_nonvarcld
    • fcst -> forecast
    • glmfed -> process_lightning
    • postanal_input -> update_lbc_soil
    • det_radarref -> det_process_radar (the enkf_radarref task name is unchanged)
    • smoke -> process_smoke

TESTS CONDUCTED:

@lgannoaa plans to test these ecflow changes on WCOSS2.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@lgannoaa

@MatthewPyle-NOAA
Copy link
Contributor

@BenjaminBlake-NOAA Should this one wait for Lin's testing?

@BenjaminBlake-NOAA
Copy link
Contributor Author

@MatthewPyle-NOAA This one can be merged now if it looks okay to you. If there are any issues Lin and I can include them in PR #539

@BenjaminBlake-NOAA
Copy link
Contributor Author

@MatthewPyle-NOAA Actually hold off on merging this one for now. Lin wants to run an ecflow test first. There are also a few additional changes needed to exrrfs_fsm.sh.

@MatthewPyle-NOAA
Copy link
Contributor

Okay - I'll wait. Inspecting ecflow PRs is impossible on github.

@BenjaminBlake-NOAA
Copy link
Contributor Author

Agreed. It may be easiest to check out my feature branch and look at the changes there instead of on GitHub. Once @lgannoaa completes a test I'll mark this PR as ready for review - converting it back to a draft for now.

@BenjaminBlake-NOAA BenjaminBlake-NOAA marked this pull request as draft November 7, 2024 14:16
@lgannoaa
Copy link
Contributor

lgannoaa commented Nov 7, 2024

Thank you @BenjaminBlake-NOAA for the excellent team work on this PR. It is a major step and open up clear path going forward.

@BenjaminBlake-NOAA BenjaminBlake-NOAA marked this pull request as ready for review November 20, 2024 20:46
@BenjaminBlake-NOAA
Copy link
Contributor Author

BenjaminBlake-NOAA commented Nov 20, 2024

@MatthewPyle-NOAA The changes for the ecflow configuration files associated with the main branch are ready to be merged. Thanks

Copy link
Contributor

@lgannoaa lgannoaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ecflow workflow configuration update associated with "main" branch in development. This version have been tested with ecflow workflow. Issue and fixes were documented.
Special thanks to @BenjaminBlake-NOAA for excellent teamwork in assistance to debug/fix activity.

Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this update has been well tested by @BenjaminBlake-NOAA and @lgannoaa , so will approve and merge

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 579b1a4 into NOAA-EMC:main Nov 20, 2024
2 checks passed
@BenjaminBlake-NOAA BenjaminBlake-NOAA deleted the feature/ecflow branch November 20, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants