-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update task names in ecflow workflow #544
Update task names in ecflow workflow #544
Conversation
@BenjaminBlake-NOAA Should this one wait for Lin's testing? |
@MatthewPyle-NOAA This one can be merged now if it looks okay to you. If there are any issues Lin and I can include them in PR #539 |
@MatthewPyle-NOAA Actually hold off on merging this one for now. Lin wants to run an ecflow test first. There are also a few additional changes needed to exrrfs_fsm.sh. |
Okay - I'll wait. Inspecting ecflow PRs is impossible on github. |
Agreed. It may be easiest to check out my feature branch and look at the changes there instead of on GitHub. Once @lgannoaa completes a test I'll mark this PR as ready for review - converting it back to a draft for now. |
Thank you @BenjaminBlake-NOAA for the excellent team work on this PR. It is a major step and open up clear path going forward. |
@MatthewPyle-NOAA The changes for the ecflow configuration files associated with the main branch are ready to be merged. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ecflow workflow configuration update associated with "main" branch in development. This version have been tested with ecflow workflow. Issue and fixes were documented.
Special thanks to @BenjaminBlake-NOAA for excellent teamwork in assistance to debug/fix activity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this update has been well tested by @BenjaminBlake-NOAA and @lgannoaa , so will approve and merge
DESCRIPTION OF CHANGES:
TESTS CONDUCTED:
@lgannoaa plans to test these ecflow changes on WCOSS2.
Machines/Platforms:
Test cases:
ISSUE:
CONTRIBUTORS (optional):
@lgannoaa