Update jobid definition for all J-jobs #535
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION OF CHANGES:
$jobid
needs to be used when setting the run directory names.$jobid
is defined at the job card level as$job.$PBS_JOBID
.$job
is the<jobname>
tag in Rocoto (and whatever the equivalent is in ecflow), and$PBS_JOBID
is a sequence of letters/numbers that is specific to each individual task. In this PR, we introduce a temporary variable called$taskid
which is defined at the job card level in the Rocoto xml, and is passed into the J-jobs where$jobid
is set and used to define the run directory ($DATA=$DATAROOT/$jobid
).$jobid = $job.$PBS_JOBID
because then other jobs in the workflow cannot access the run directories for other tasks. Once workflow changes are made to utilize the umbrella data directory structure described in issue directory structures:com
,umbrella
,$DATA
#498 then we can shift to using$jobid = $job.$PBS_JOBID
everywhere, and the temporary$taskid
variable will be removed.$jobid
definition just yet (see note above):export jobid=${jobid:-${taskid}}
TESTS CONDUCTED:
Completed a successful spinup cycle with the DA engineering test. @hu5970 has offered to assist with testing these changes.
Machines/Platforms:
Test cases:
ISSUE: