Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-sci] Fix issues with real-time parallel related to SAS #495

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

BenjaminBlake-NOAA
Copy link
Contributor

DESCRIPTION OF CHANGES:

  • This PR fixes three small issues related to using the saSAS convective scheme in the real-time parallel:
  • parm/FV3.input.yml_ensphy is updated to fix the issues with the ensemble namelist generation. imfdeepcnv, betadcu, and progsigma are now set properly for each ensemble member.
  • "RRFS_sas" is added as a CCPP suite option to scripts/exrrfs_run_fcst.sh so that the oro_data_ls and oro_data_ss (orographic GWD suite files) can be located by the forecast task.
  • A diag_table.RRFS_sas_clm file is added to the parm directory, which is needed by the forecast task.
  • A similar PR to production/RRFS.v1 will be made today.

TESTS CONDUCTED:

These changes have been tested in the real-time parallel. I also ran an offline test to generate the ensemble member namelists, and they are now generated correctly.

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others:

ISSUE:

CONTRIBUTORS (optional):

@JiliDong-NOAA @ShunLiu-NOAA @MatthewPyle-NOAA

Copy link
Contributor

@ShunLiu-NOAA ShunLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving...

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 104316e into NOAA-EMC:dev-sci Sep 19, 2024
1 check passed
MatthewPyle-NOAA pushed a commit that referenced this pull request Sep 19, 2024
@BenjaminBlake-NOAA BenjaminBlake-NOAA deleted the feature/SAS branch September 24, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants