Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switches for execuables in rrfs-utl #141

Merged
merged 6 commits into from
Dec 7, 2023

Conversation

chan-hoo
Copy link
Contributor

@chan-hoo chan-hoo commented Dec 2, 2023

DESCRIPTION OF CHANGES:

  • Add switches not to compile the unused executables in the RRFS workflow.
  • The following source directories in rrfs-utl are not used in the scripts. However, all executables are compiled by default for development. When RRFS is delivered later, these can be turned off if they are not necessary.
gen_cs
FV3_ensmean_recenter
lakesurgery
radmon
rtma_minmaxtrh

TESTS CONDUCTED:

  • On machines/platforms:
  • WCOSS2

  • Hera

  • Orion

  • Jet

  • Test cases:

  • Non-DA engineering test
  • DA engineering test
  • Other sample scripts:

ISSUE:

Dependency:

@chan-hoo chan-hoo linked an issue Dec 2, 2023 that may be closed by this pull request
@chan-hoo
Copy link
Contributor Author

chan-hoo commented Dec 2, 2023

@MatthewPyle-NOAA, RADMON is not compiled in this PR because its executables are not used in any scripts of the RRFS workflow. However, according to NOAA-GSL/rrfs_utl#43, it seems that we would need to compile it. Can you confirm this?

"-DUPDATE_ICE=ON"
"-DUPDATE_SNOW=ON"
"-DUPDATE_SST=ON"
"-DUSE_RAPHRRR_SFC=ON"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retro experiments will need FV3_ENSMEAN_RECENTER, LAKESURGERY(?)

Is it possible to turn on all rrfs_utl executables by default and then use command line options to only build executables required by operation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guoqing-noaa, good suggestion. I'll turn all of them on by default at this moment. We can adjust them later when it is delivered.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo Sorry for the slow response. I believe that radiance monitoring will be done outside of the main RRFS workflow.

Copy link
Contributor

@MatthewPyle-NOAA MatthewPyle-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizing there is no reason to hold this one up - will approve and merge so @chan-hoo doesn't need to keep updating his branch.

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 4a7e3f8 into NOAA-EMC:dev-sci Dec 7, 2023
@chan-hoo chan-hoo deleted the ee2/switch_utl branch December 11, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need switches not to compile unnecessary executables in rrfs-utl
3 participants