-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI build #730
Add CI build #730
Conversation
@junwang-noaa can you review this PR? This is needed for both documentation and unit testing work. |
@AlexanderRichert-NOAA when the UFS is build by spack, is fv3atm one of the packages it builds? Or does it build fv3atm as part of another package, using the git submodule method to get the fv3atm code? |
The CMakeLists.txt of ufs-weather-model uses |
Latest runs are at https://github.com/AlexanderRichert-NOAA/fv3atm/actions/runs/7414791796 |
@edwardhartnett if you're able to approve this I think it's good to go |
@junwang-noaa can you recommend a second "approved" reviewer (I take it that Ed is not one)? If we can get this merged, I'll follow it up with the addition of the unit test infrastructure, including the first one or two unit tests. |
@BrianCurtis-NOAA Dusan is on leave, I added you to review. Please note that other FV3 PRs may need to be synced when this PR is committed. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i look forward to seeing how this works!
@junwang-noaa I believe this is ready to be merged |
Description
This PR adds a GCC11-and-MPICH-based CI workflow for building fv3atm, on top of which unit tests can be added. Dependencies are installed through Spack, where the installation directory is cached between runs for a significant speed up.
Issue(s) addressed
Addresses #729
Testing
Tested standalone build on personal machine and GH Actions. Built under ufs-weather-model on personal machine.
Dependencies
none