Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant surface variable cleanup #317

Closed
wants to merge 5 commits into from

Conversation

mzhangw
Copy link
Contributor

@mzhangw mzhangw commented May 25, 2021

Description

placeholder

Associated PR: NCAR/ccpp-physics#659
(Instructions: this, and all subsequent sections of text should be removed and filled in as appropriate.)
Provide a detailed description of what this PR does.
What bug does it fix, or what feature does it add?
Is a change of answers expected from this PR?

Issue(s) addressed

Link the issues to be closed with this PR, whether in this repository, or in another repository.
(Remember, issues should always be created before starting work on a PR branch!)

  • fixes #<issue_number>
  • fixes noaa-emc/fv3atm/issues/<issue_number>

Testing

How were these changes tested?
What compilers / HPCs was it tested with?
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
Have the ufs-weather-model regression test been run? On what platform?

  • Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
  • Please commit the regression test log files in your ufs-weather-model branch

Dependencies

If testing this branch requires non-default branches in other repositories, list them.
Those branches should have matching names (ideally)

Do PRs in upstream repositories need to be merged first?
If so add the "waiting for other repos" label and list the upstream PRs

  • waiting on noaa-emc/nems/pull/<pr_number>
  • waiting on noaa-emc/fv3atm/pull/<pr_number>

@climbfuji
Copy link
Collaborator

@mzhangw can you please also create a ufs-weather-model PR? And address the review comments I left in NCAR/ccpp-physics#679 and #317? Thanks!

@climbfuji climbfuji added the bug Something isn't working label Jul 29, 2021
@climbfuji
Copy link
Collaborator

This PR is on hold until the issues in NCAR/ccpp-physics#659 are resolved.

@climbfuji climbfuji added the wontfix This will not be worked on label Aug 5, 2021
@climbfuji
Copy link
Collaborator

This PR will be replaced with a new one once the issues are resolved.

@climbfuji climbfuji closed this Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants