Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more tests for addfield() #721

Merged
merged 11 commits into from
Jul 1, 2024
Merged

Adding more tests for addfield() #721

merged 11 commits into from
Jul 1, 2024

Conversation

AlysonStahl-NOAA
Copy link
Contributor

Part of #377

edwardhartnett
edwardhartnett approved these changes Jun 29, 2024
View reviewed changes
Copy link
Contributor

@edwardhartnett edwardhartnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like good test code. If you mark this ready for review, I can merge...

@AlysonStahl-NOAA AlysonStahl-NOAA marked this pull request as ready for review July 1, 2024 14:16
@edwardhartnett edwardhartnett merged commit 95a18f8 into NOAA-EMC:develop Jul 1, 2024
47 checks passed
@AlysonStahl-NOAA AlysonStahl-NOAA deleted the as_addfield branch July 1, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwardhartnett edwardhartnett edwardhartnett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlysonStahl-NOAA @edwardhartnett