Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing for addfield.f #377

Open
edwardhartnett opened this issue May 12, 2023 · 1 comment
Open

Improve testing for addfield.f #377

edwardhartnett opened this issue May 12, 2023 · 1 comment
Assignees
Labels
test Testing is important!

Comments

@edwardhartnett
Copy link
Contributor

There are a lot of conditions in this code that are not being tested.

@edwardhartnett edwardhartnett added the test Testing is important! label May 12, 2023
@edwardhartnett
Copy link
Contributor Author

With recent merges much of the easy testing has been done, and remaining testing involves some grib complexities.

  1. bitmaps - some GRIB messages have them, but I have no examples to work with (yet).
  2. different types of compression, currently only simpack() is tested.

Of these, 2 looks easiest to tackle. Getting JPEG and PNG compression working in tests would be very helpful. This would mean changing the DRS template array (idrstmpl in the parameter list of addfield()). By setting the DRS template to the appropriate size and values, different compression types can be specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Testing is important!
Projects
Status: In progress
Development

No branches or pull requests

2 participants