-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build scripts (rust 1.81) #149
Conversation
@race-of-sloths ping |
@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 6! What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
@race-of-sloths score 5 |
Great to see the new build scripts and that they are now integrated into the tests! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good to me, but please check the codespace issue ( consider merging #148 first )
.devcontainer/post-create.sh
Outdated
cargo near build | ||
curl --proto '=https' --tlsv1.2 -LsSf https://github.com/near/near-cli-rs/releases/latest/download/near-cli-rs-installer.sh | sh | ||
|
||
curl --proto '=https' --tlsv1.2 -LsSf https://github.com/near/cargo-near/releases/latest/download/cargo-near-installer.sh | sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cargo-near fails to install in the ghcr.io/near/near-devcontainer image.
2024-09-10 19:39:47.137Z: downloading cargo-near 0.8.2 x86_64-unknown-linux-gnu
2024-09-10 19:39:48.739Z: installing to /usr/local/cargo/bin
2024-09-10 19:39:48.743Z: cp: cannot create regular file '/usr/local/cargo/bin/cargo-near': Permission denied
2024-09-10 19:39:48.748Z: ERROR�(B�[m: command failed: cp /tmp/tmp.NHfv1kPqDY/cargo-near /usr/local/cargo/bin
Consider applying the change from here:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petersalomonsen i overlooked that change in .devcontainer/devcontainer.json
when copying from #148 ,
only copied from .devcontainer/post-create.sh
.
i'll add it too
@petersalomonsen i've added back |
Great ! Thanks! |
@race-of-sloths score 8 |
std::fs:read
of wasm inputs--no-docker
everywhere aftercargo near build
community
->discussions
community-factory
->community