Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional kyc check for review stage #138

Conversation

PolyProgrammist
Copy link
Collaborator

@PolyProgrammist PolyProgrammist commented Jul 1, 2024

Closes NEAR-DevHub/neardevhub-bos#848 - adds additional kyc check for review stage.

For that, VersionedTimelineStatus along with TimelineStatusV1 is introduced

Also it removes posts functionality for the following reason:

Action #0: ExecutionError("Exceeded the prepaid gas.")

It arises on calling either unsafe_self_upgrade or unsafe_migrate on test_deploy_contract_self_upgrade test.
You can check kyc-review branch for that
And I see the only reason is the code size as it exceeds 1.1 MB. So code for posts was removed. No migrations needed for that as there are no posts on devhub.near. Just one test post

@PolyProgrammist PolyProgrammist changed the title Kyc review after removed posts feat: additional kyc check for review stage Jul 1, 2024
@PolyProgrammist PolyProgrammist marked this pull request as ready for review July 1, 2024 04:16
@PolyProgrammist PolyProgrammist requested a review from frol July 1, 2024 04:16
src/proposal/repost.rs Outdated Show resolved Hide resolved
src/proposal/timeline.rs Outdated Show resolved Hide resolved
src/proposal/timeline.rs Outdated Show resolved Hide resolved
src/notify.rs Outdated Show resolved Hide resolved
@PolyProgrammist PolyProgrammist merged commit dcb78f1 into NEAR-DevHub:main Jul 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move KYC/KYB proposal timeline step from Payment Processing to Review stage
2 participants