feat: add set_social_db_profile_description #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolyProgrammist
requested review from
frol and
petersalomonsen
and removed request for
frol
petersalomonsen
suggested changes
Jun 6, 2024
There was a problem hiding this comment.
Should we also store the description in the contract storage? So that it can also be used by the web4 handler here:
https://github.com/NEAR-DevHub/neardevhub-contract/blob/main/src/web4/handler.rs#L23
Then we would also be able to show descriptions for other instances such as events/infrastructure-committee.
|
@petersalomonsen I think we don't need that after all. Web4 supports view-calls that it resolves on the gateway level, see "Loading data" section https://web4.near.page/ |
frol
approved these changes
Jun 7, 2024
|
True, let's try the web4 preloads instead 👍 |
petersalomonsen
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested here: https://near.social/mob.near/widget/ProfilePage?accountId=truedove38.near