Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace initial condition to evolving condition #277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace initial condition to evolving condition #277

wants to merge 2 commits into from

Conversation

montythind
Copy link
Contributor

Pr include the changes to replace initial condition to evolving condition when time = 0

closes #260

@montythind
Copy link
Contributor Author

I guess the question outstanding is:
can there be a scenerio, where inital condition is set but the time.s doesn't start with 0?
If yes, do we still replace the initial values with evolving?
@K20shores

K20shores
K20shores approved these changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@K20shores K20shores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K20shores K20shores K20shores approved these changes

@mattldawson mattldawson Awaiting requested review from mattldawson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evolving conditions and initial conditions are not correctly synchronized
2 participants
@montythind @K20shores