Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconciliation from production/RRFS.v1 branch to main #596

Closed
wants to merge 3 commits into from

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 3, 2024

This PR copies the changes for the production/RRFS.v1 branch back to the main branch for the purposes of full UFS testing.

The only divergent PR in the production/RRFS.v1 branch was #536.
This is @climbfuji 's work. Given #529, I'm not sure if this is needed
or not. I recall that this was part of a "temporary" solution to the RRFSv1 release branch, but I'm not sure if
subsequent solutions made their way into main yet.

User interface changes?: No

Fixes:

Testing:
test removed:
unit tests:
system tests:
manual testing:

@grantfirl
Copy link
Collaborator Author

grantfirl commented Oct 3, 2024

@dustinswales @climbfuji I can't recall if this is needed or not (whether other optional argument work has already made its way into the main branch such that -check all can successfully be used in UFS without this). It's been a while since I paid attention to this.

@climbfuji
Copy link
Collaborator

I believe these changes are not intended to go into main.

@grantfirl
Copy link
Collaborator Author

I believe these changes are not intended to go into main.

Thanks, I thought that was the case, but couldn't remember. I need to run some tests with UFS with -check all on the main branch without these changes to make sure, I guess.

@climbfuji
Copy link
Collaborator

I believe these changes are not intended to go into main.

Thanks, I thought that was the case, but couldn't remember. I need to run some tests with UFS with -check all on the main branch without these changes to make sure, I guess.

The development in main (redo how opt args are done) should take care of this - eventually if not already.

This code in the RRFS branch was a quick-n-dirty workaround for being able to compile with -check all. THe associated metadata changes (in_inactive, out_inactive) must also be kept out from ccpp-physics main.

@mkavulich
Copy link
Collaborator

Per discussion this PR is not needed

@mkavulich mkavulich closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants