Apply suggestions from code review

NCAR · Oct 9, 2024 · 8c8b604 · 8c8b604
1 parent 02b9393
commit 8c8b604
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 9 deletions.
diff --git a/test_prebuild/run_all_tests.sh b/test_prebuild/run_all_tests.sh
@@ -8,4 +8,4 @@ echo "" && echo "Running test_blocked_data" && cd test_blocked_data && ./run_tes
 echo "" && echo "Running test_chunked_data" && cd test_chunked_data && ./run_test.sh  && cd ..
 echo "" && echo "Running test_unit_conv"    && cd test_unit_conv    && ./run_test.sh  && cd ..
 
-echo "" && echo "Running test_track_variables" && pytest test_track_variables.py
+echo "" && echo "Running test_track_variables" && pytest test_track_variables.py
diff --git a/test_prebuild/test_unit_conv/README.md b/test_prebuild/test_unit_conv/README.md
@@ -1,16 +1,16 @@
-# How to build the chunked data test
+# How to build the unit conv test
 
 1. Set compiler environment as appropriate for your system
 2. Run the following commands:
 ```
-cd test_prebuild/test_chunked_data/
+cd test_prebuild/test_unit_conv/
 rm -fr build
 mkdir build
 ../../scripts/ccpp_prebuild.py --config=ccpp_prebuild_config.py --builddir=build
 cd build
 cmake .. 2>&1 | tee log.cmake
 make 2>&1 | tee log.make
-./test_chunked_data.x
+./test_unit_conv.x
 # On systems where linking against the MPI library requires a parallel launcher,
-# use 'mpirun -np 1 ./test_chunked_data.x' or 'srun -n 1 ./test_chunked_data.x' etc.
+# use 'mpirun -np 1 ./test_unit_conv.x' or 'srun -n 1 ./test_unit_conv.x' etc.
 ```
diff --git a/test_prebuild/test_unit_conv/data.F90 b/test_prebuild/test_unit_conv/data.F90
@@ -16,7 +16,6 @@ module data
     integer, parameter :: ncols = 4
     integer, parameter :: nspecies = 2
     type(ccpp_t), target :: cdata
-    !real(kind_phys), dimension(1:ncols,1:nspecies), target :: data_array
     real(kind_phys), dimension(1:ncols,1:nspecies) :: data_array
     logical :: opt_array_flag
 

diff --git a/test_prebuild/test_unit_conv/data.meta b/test_prebuild/test_unit_conv/data.meta
@@ -50,4 +50,4 @@
   dimensions = (horizontal_loop_extent)
   type = real
   kind = kind_phys
-  active = (flag_for_opt_array)
+  active = (flag_for_opt_array)
diff --git a/test_prebuild/test_unit_conv/main.F90 b/test_prebuild/test_unit_conv/main.F90
@@ -89,4 +89,4 @@ program test_unit_conv
 
 contains
 
-end program test_unit_conv
+end program test_unit_conv
diff --git a/test_prebuild/test_unit_conv/unit_conv_scheme_2.meta b/test_prebuild/test_unit_conv/unit_conv_scheme_2.meta
@@ -38,4 +38,4 @@
   type = real
   kind = kind_phys
   intent = inout
-  optional = True
+  optional = True