Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restart server command in vscode #894

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Eric-Song-Nop
Copy link
Collaborator

The upstream bugs might crash the language server in many cases, I feel it a requirement to have an explicit way to restart the language server client in such case.

@Myriad-Dreamin
Copy link
Owner

Some thoughts:

  • We could detect and restart the server once after user editing typst document. It is not done intermediately after server down, to avoid infinite or aggressively restart.
  • The right-below status bar could hints the user that currently the server is down for some reason, e.g. "Crashed", hovering with message "Compiler panicked: blabla".

@Myriad-Dreamin
Copy link
Owner

I refactored code to help ensure that all resources are disposed when deactivating the extension. Otherwise we'll not be able to restart reliably. It is better to separate a PR, but we can also merge the two commits in this PR if we both are lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants