-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove out-of-date versioneer import #158
base: main
Are you sure you want to change the base?
Conversation
I think the migration from Thanks for finding! |
I think I was looking at the commit date, not the merge date 🤦 that makes more sense |
So the What I suspect happened is you attempted to run the code without first installing it, so the file wasn't there and wasn't imported. If this is a use case for you, then its an edge case we should support. I think the solution here would be to create Thoughts? |
Good to know, thanks for the explanation! Yes, we should document or explain this. We can add a try except with a comment explaining what's happening. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to make changes suggested by @Lnaden
Note that the file is generated in several other instances in which versioningit is invoked, such as when building the package, even as an sdist, or (possibly) when using the versioningit command line tool to check the version. I'm not sure I agree with a |
Hi!
I might just be thick, but I'm getting
ModuleNotFoundError: No module named 'projectname._version'
when loading a new project in a Python interpreter or Sphinx. I think this line is just left over from the versioneer -> versioningit transition, but I'm surprised no one has reported it in nearly a month!